[Bug 1125536] Convert all rate limiting to a standard helper.#2363
Merged
rlr merged 3 commits intomozilla:masterfrom Feb 12, 2015
Merged
[Bug 1125536] Convert all rate limiting to a standard helper.#2363rlr merged 3 commits intomozilla:masterfrom
rlr merged 3 commits intomozilla:masterfrom
Conversation
Contributor
Author
|
All the boxes above are checked. I think this is ready to go. r? |
Contributor
|
but that test fails. gah! |
Contributor
Author
|
Oops, I forgot to git add the migration that creates the permission. That is why the test failed. |
Contributor
Author
|
🎆 |
rlr
added a commit
that referenced
this pull request
Feb 12, 2015
[Bug 1125536] Convert all rate limiting to a standard helper.
Contributor
|
yay 💥 |
This was referenced Jul 10, 2020
This was referenced Aug 16, 2020
This was referenced Mar 22, 2022
This was referenced Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts all the rate limiting we have to use two related functions
kitsune.sumo.decorators.ratelimitandkitsune.sumo.utils.is_ratelimited. These work largely like their django-ratelimit versions, and in-fact use django-ratelimit themselves, except they are simplified and specialized to our needs. In particular, they respect a permission for bypassing rate limits, so we can have a global switch for this, and they all log when a user is over the rate limit.The rate limit overages are recorded in
kitsune.journal.models.Record, which is loosely based offfjord.journal.models.Record, which @willkg wrote. I modified it a lot, since I don't think we needed everything Fjord needed.This isn't done yet
ratelimitdecorator.is_ratelimitedfunction.f?